fix: show not found page for invite and members page on archived room#69002
Conversation
|
@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@alitoshmatov Friendly bump. |
|
Failing checks are not related to this PR. |
|
@alitoshmatov we're good to go. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp404-android.movAndroid: mWeb Chrome404-mweb.moviOS: HybridApp404-ios.mp4iOS: mWeb Safari404-safari.mp4MacOS: Chrome / Safari404-web.movMacOS: Desktop404-desktop.mov |
trjExpensify
left a comment
There was a problem hiding this comment.
Could we perhaps use copy that's more discerning to the case of the room being archived here? CC: @jamesdeanexpensify
|
@trjExpensify thoughts?
|
|
Works for me! |
|
@samranahm bump on the new requested changes above^ |
|
Will update the copy shortly. |
|
@jasperhuangg we're good to go. |
jasperhuangg
left a comment
There was a problem hiding this comment.
Nice, thanks, gonna leave it for @trjExpensify for one last look, but code checks out
|
Looks good! |
|
🚀 Deployed to staging by https://github.com/jasperhuangg in version: 9.2.9-0 🚀
|
|
🚀 Deployed to staging by https://github.com/jasperhuangg in version: 9.2.11-0 🚀
|
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.2.12-4 🚀
|

Explanation of Change
When we delete a workspace and had some rooms associated with that workspace, user can access the members page and invite members page but is not expected behaviour since the room is no more available, let's add not found page on both pages and fix back navigation on invite page to prevent showing another not found page (members page) when user press backButton on invite page
Fixed Issues
$ #67005
PROPOSAL: #67005 (comment)
Tests
Offline tests
QA Steps
same as test
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android.native.mp4
Android: mWeb Chrome
Android.mWeb.chrome.mp4
iOS: Native
IOS.native.mp4
iOS: mWeb Safari
mWeb.safari.mp4
MacOS: Chrome / Safari
macOS.chrome.mp4
MacOS: Desktop
Desktop.mp4